Skip to content

docs: repoint all 18 leaked claude.ai chat links to real targets - #2351

Open
simpleqt wants to merge 2 commits into
MemTensor:mainfrom
simpleqt:docs/contributing-broken-anchor-links
Open

simpleqt wants to merge 2 commits into
MemTensor:mainfrom
simpleqt:docs/contributing-broken-anchor-links

Conversation

@simpleqt

@simpleqt simpleqt commented Sep 8, 2026

Copy link
Copy Markdown

CONTRIBUTING.md's entire Table of Contents, an inline test-docs link, the Code of Conduct references, and the license link pointed at https://claude.ai/chat/<conversation-id>#anchor — a private AI chat session that leaked into the file, so every TOC entry 404'd.

  • All 15 TOC/inline entries now use the in-file anchors that already exist in the document
  • The Code of Conduct references point at CODE_OF_CONDUCT.md and the license link at LICENSE (both in-repo)

Docs-only.

The CONTRIBUTING.md TOC, an inline test-docs link, the Code of Conduct
references and the license link all pointed at
https://claude.ai/chat/<conversation-id>#... — a private AI chat
session that leaked into the file. TOC entries now use in-file anchors;
CoC/license links point at CODE_OF_CONDUCT.md and LICENSE.
Copilot AI lite review requested due to automatic review settings September 8, 2026 22:22
@Memtensor-AI Memtensor-AI added area:core MOS 编排层 / 框架底座 / 跨模块问题 status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

🤖 Open Code Review

Target: PR #2351
Task: f008a9e59b275bcc
Base: main
Head: docs/contributing-broken-anchor-links

OpenCodeReview: Review skipped: no items were selected.

Generated by cloud-assistant via Open Code Review.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

✅ Automated Test Results: PASSED

All tests passed (6/6 executed). common/smoke: 6/6. Duration: 2s

Branch: docs/contributing-broken-anchor-links

@Memtensor-AI Memtensor-AI added status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发 and removed status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Sep 8, 2026
@TankLin23

Copy link
Copy Markdown

Heads-up: the anchor targets here won't resolve either — the hyphens are missing.

CONTRIBUTING.md doesn't use regular spaces. It uses U+00A0 (NBSP) as its word separator throughout — 1405 of them against 433 real spaces — and 29 of the file's 35 headings contain them. ## Ways to Contribute is really ## Ways<NBSP>to<NBSP>Contribute.

GitHub strips NBSP when generating the anchor instead of turning it into a hyphen, so the real ids have no hyphens. On the rendered page today:

## Ways to Contribute  ->  #waystocontribute   (not #ways-to-contribute)
## Review Process      ->  #reviewprocess
## Code of Conduct     ->  #codeofconduct

Visible directly at
https://github.com/MemTensor/MemOS/blob/main/CONTRIBUTING.md — the permalink href on a heading is #waystocontribute.

Contrast with README.md in this same repo: 0 NBSP, and its anchors do carry hyphens (#key-features, #quick-start). Same renderer, so NBSP is the only variable.

Of the 18 links changed here, 14 still 404 once this merges. The ones that work are #community, #license, #recognition and LICENSE — single-word anchors have no space to lose.

Second thing: the two CODE_OF_CONDUCT.md links point at a file that does not exist. There is no Code of Conduct anywhere in the repo — it is not in the root listing, code search returns 0, and

https://raw.githubusercontent.com/MemTensor/MemOS/main/CODE_OF_CONDUCT.md   -> 404

So line 432's "See our Code of Conduct for the reporting email" cannot be satisfied by a link at all; either that file gets added, or the sentence needs rewording.

For the anchors there are two ways out:

(a) point them at the ids that actually exist (#waystocontribute, #beforeyoustart, ...) — small diff, works today, but fragile, since normalizing the NBSPs later would break them all again;
(b) replace the NBSPs in the headings with regular spaces, after which the normal hyphenated anchors work — touches more of the file, but removes the cause. It would also fix this file's plain-text search and copy behaviour, which the NBSPs currently corrupt.

Happy to send (b) as a separate patch if that is the direction you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core MOS 编排层 / 框架底座 / 跨模块问题 status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants